ci: add a builds aggregation gate to require all host builds#478
Merged
Conversation
A single 'all-builds' job needs the whole build matrix and fails unless every leg succeeded, so it can be the one required status for merging instead of the dynamic per-host names. Named 'all-builds' (paired with the Checks workflow's 'all-checks' gate) since branch protection matches required checks by bare job name. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
281240c to
eab60ce
Compare
etrobert
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add an
all-buildsaggregation gate to theBuildworkflow so all host builds can be required for merging via one stable status, instead of the dynamic per-host names (tower,leod,pi,aaron).needs: buildrequires the whole matrix job, which isfailureif any host leg fails (fail-fast: false), so every dynamically-discovered host is transitively required — add a machine to the flake and it's covered automatically, no branch-protection edit.if: always()makes the gate run even when a build fails (a skipped required check would otherwise count as passing).Naming
Paired with the
Checksworkflow's gate, renamed in tandem toall-checks/all-builds— symmetric and unique (branch protection matches by bare job name, so both can't beall).Follow-up (you, in branch protection)
Require
all-checksandall-buildsformain(replacingall).Verification
actionlint,yamllint --strict→ clean